fix memory leak and maintain joysticks list #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
SDL_Joysticks.cpp:342 This pull request introduces a bug where the joystick axes array is indexed with the button code, causing an index out of range crash everytime a button with a button code higer than the number of axes is pressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed the memory leak problem, but it seems cause error for the example program.
I'm not familiar with QML, so please have a further examination.
Besides, I strongly recommend to upgrade SDL version into 2.0.10+, because Game Controller Database no longer support older version, and some problem like this issue is no longer a problem.