nzxt-kraken3: Add a timeout to the secondary reader wait_event call

In the unlikely case that a reader gets stuck there under weird circumstances, give it an automatic way out. Signed-off-by: Aleksa Savic <[email protected]>
aleksamagicka · Oct 1, 2023 · a9b09a6 · a9b09a6
1 parent 05f50e2
commit a9b09a6
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/nzxt-kraken3.c b/nzxt-kraken3.c
@@ -272,9 +272,10 @@ static int kraken3_read(struct device *dev, enum hwmon_sensor_types type, u32 at
  if (ret < 0)
  return ret;
  } else {
- /* Wait for the main reader */
- if (wait_event_interruptible
- (priv->z53_reader_wq, priv->z53_status_processed))
+ /* Wait for the main reader with a timeout of 2 * STATUS_VALIDITY */
+ if (wait_event_interruptible_timeout
+ (priv->z53_reader_wq, priv->z53_status_processed,
+ msecs_to_jiffies(2 * STATUS_VALIDITY * 1000)) <= 0)
  return -ENODATA;
 
  /* Return saved error code if reader failed in some way */