refactor: events permissions #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slash-84
force-pushed
the
refactor/event-permissions
branch
from
dc2e097
to
de36d6c
Compare
slash-84
commented
Apr 10, 2024
| const triggerViewer = (el?: MouseEvent<Element>) => { | ||
| if (!el?.currentTarget && deleteConfirm) { | ||
| setDeleteConfirm(false); | ||
| } | ||
| setAnchorEl(el?.currentTarget || null); | ||
| }; | ||
|
|
||
| const isDraggable = useMemo(() => { | ||
| // if Disabled | ||
| if (event.disabled || !editable) return false; |
There was a problem hiding this comment.
@aldabil21 inside the hook you will see I've removed event.disabled check because the button is already disabled, and the drag & drop is already prevented. This will help to implement priority control to event specific data.
slash-84
force-pushed
the
refactor/event-permissions
branch
from
de36d6c
to
5a7a05b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move event permissions logic inside dedicate hook.
also address #343 (comment) for editable events, using priority control to event specific value