fix: fix middleware service clone. #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysim3d
requested review from
dancoombs,
dphilipson,
0xfourzerofour and
alex-miao
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
|
andysim3d
force-pushed
the
andy/middleware-fix
branch
from
bcf4eee
to
1dca5f0
Compare
0xfourzerofour
approved these changes
Nov 1, 2024
dancoombs
reviewed
Nov 4, 2024
|
|
||
| priority_fee_oracle_type = "USAGE_BASED" | ||
| min_max_priority_fee_per_gas = 30000000000 | ||
| bloxroute_enabled = true |
dancoombs
reviewed
Nov 4, 2024
| id = 5611 | ||
|
|
||
| priority_fee_oracle_type = "USAGE_BASED" | ||
| min_max_priority_fee_per_gas = 30000000000 |
There was a problem hiding this comment.
Just wondering, where did this come from?
There was a problem hiding this comment.
this is for local test only. I copied it from polygon.
There was a problem hiding this comment.
Got it, if just used for your local testing we should remove this from the repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Closes/Fixes] #
reference: https://docs.rs/tower/latest/tower/trait.Service.html#be-careful-when-cloning-inner-services
Proposed Changes