Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(builder): don't wait for next block after bundle mine in auto #892

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

dancoombs
Copy link
Collaborator

Proposed Changes

  • Old code would always wait for the next block after a bundle was mined. Instead, if in auto bundling mode, we should immediately begin to build the next bundle after a bundle is mined.

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review.

Project coverage is 58.72%. Comparing base (f09781e) to head (7131c03).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/builder/src/bundle_sender.rs 64.28% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
crates/builder/src/bundle_sender.rs 73.43% <64.28%> (-0.41%) ⬇️
Flag Coverage Δ
unit-tests 58.72% <64.28%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <ø> (ø)
builder 63.23% <64.28%> (-0.08%) ⬇️
dev ∅ <ø> (∅)
pool 66.74% <ø> (ø)
provider 20.84% <ø> (ø)
rpc 25.87% <ø> (ø)
sim 76.76% <ø> (ø)
tasks ∅ <ø> (∅)
types 67.83% <ø> (ø)
utils 29.38% <ø> (ø)

@dancoombs dancoombs merged commit 25a749c into main Oct 30, 2024
11 checks passed
@dancoombs dancoombs deleted the danc/fix-trigger-wait branch October 30, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants