Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use type erasure on types with lots of generics #865

Closed
wants to merge 1 commit into from

Conversation

dancoombs
Copy link
Collaborator

Applies this pattern in 3 places:

  • Providers for tasks (reused by all tasks)
  • UO Pool
  • Bundler Proposer

I like the first one, but the second two seem to bring out too much boilerplate and the types aren't reused. Want to see if I can simplify a bit using some sort of composition, but if I can't simplify I may just keep the first one.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 54.76190% with 95 lines in your changes missing coverage. Please review.

Project coverage is 57.77%. Comparing base (f49a95e) to head (7a0c5a4).

Files with missing lines Patch % Lines
crates/builder/src/task.rs 0.00% 22 Missing ⚠️
crates/pool/src/task.rs 0.00% 19 Missing ⚠️
bin/rundler/src/cli/mod.rs 0.00% 13 Missing ⚠️
crates/rpc/src/task.rs 0.00% 12 Missing ⚠️
crates/builder/src/bundle_proposer.rs 90.80% 8 Missing ⚠️
crates/pool/src/mempool/uo_pool.rs 83.72% 7 Missing ⚠️
bin/rundler/src/cli/node/mod.rs 0.00% 6 Missing ⚠️
bin/rundler/src/cli/rpc.rs 0.00% 6 Missing ⚠️
bin/rundler/src/cli/builder.rs 0.00% 1 Missing ⚠️
bin/rundler/src/cli/pool.rs 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
crates/pool/src/chain.rs 93.65% <ø> (ø)
crates/pool/src/mempool/mod.rs 100.00% <ø> (ø)
bin/rundler/src/cli/builder.rs 0.00% <0.00%> (ø)
bin/rundler/src/cli/pool.rs 0.00% <0.00%> (ø)
bin/rundler/src/cli/node/mod.rs 0.00% <0.00%> (ø)
bin/rundler/src/cli/rpc.rs 0.00% <0.00%> (ø)
crates/pool/src/mempool/uo_pool.rs 89.72% <83.72%> (-0.47%) ⬇️
crates/builder/src/bundle_proposer.rs 87.67% <90.80%> (-0.04%) ⬇️
crates/rpc/src/task.rs 0.00% <0.00%> (ø)
bin/rundler/src/cli/mod.rs 0.00% <0.00%> (ø)
... and 2 more
Flag Coverage Δ
unit-tests 57.77% <54.76%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <0.00%> (ø)
builder 61.87% <72.47%> (+0.25%) ⬆️
dev ∅ <ø> (∅)
pool 64.31% <58.06%> (-0.14%) ⬇️
provider 19.79% <ø> (ø)
rpc 25.88% <0.00%> (+0.09%) ⬆️
sim 76.64% <ø> (ø)
tasks ∅ <ø> (∅)
types 67.51% <ø> (ø)
utils 29.38% <ø> (ø)

Base automatically changed from danc/da-sync to feat/v0.4 October 18, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant