Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Rundler v0.4 #849

Merged
merged 56 commits into from
Oct 23, 2024
Merged

chore: Rundler v0.4 #849

merged 56 commits into from
Oct 23, 2024

Conversation

dancoombs
Copy link
Collaborator

@dancoombs dancoombs commented Oct 15, 2024 •
edited
Loading

TODO

  • Release notes Will add to release draft
  • Documentation updates
  • Large scale testing

dancoombs and others added 25 commits October 18, 2024 11:00
@dancoombs
chore: remove dev crate and tools binaries
577b367
@dancoombs
chore: update rust version and various deps
1d71404
@dancoombs
feat(rpc): update jsonrpsee version, rework metrics middleware
c2d3656
@dancoombs
feat: inject providers from bin
e2c1a6d
@dancoombs
feat(utils): update utils to use new types
9b5213e
@dancoombs
feat(contracts): add contracts crate, remove from types
0f006e9
@dancoombs
feat(types): use alloy/native types in types crate
8c6252e
@dancoombs
feat(provider): modify provider traits for new types, impl alloy prov…
a7d7ba6 
…ider
@dancoombs
feat(task): update task crate to alloy
ee71636
@dancoombs
feat(sim): update sim crate to use alloy types
392eecb
@andysim3d @dancoombs
feat(middleware): create a generic middleware to collect method metri…
9b54578 
…cs. (#804)
@dancoombs
feat(pool): update pool to use alloy types
f958df1
@andysim3d @dancoombs
fix(middleware): change mod visibility to pass build. (#815)
04e5d01
@dancoombs
feat(rpc): modify rpc to use alloy types
a8f4df9
@dancoombs
feat(builder): update builder crate to alloy types
9ab7b4d
@dancoombs
feat(bin): update binary to alloy, pass spec tests w/ fixes
0794953
@dancoombs
fix(build): fix contracts build
7ae283e
@dancoombs
feat: update alloy to v0.4, fix types
50e90dd
@dancoombs
feat: replace existing tasks with reth tasks
31eba9a
@dancoombs
chore: update rust to 1.81
ce67cf6
@dancoombs
fix(provider): use latest for fee history in pending base fee
2385a4e
@andysim3d @dancoombs
test(evm): add getCodeHash unit test. (#826)
d76e270
@dancoombs
fix(builder): don't forget underpriced info when no ops
ba7ae8b
@dancoombs
refactor: modify uo gas limit calcs & v0.6 builder
31a1505
@dancoombs
feat(types): improve handling of bundle size in pvg gas limits
3b3e4b9
dancoombs and others added 15 commits October 18, 2024 11:12
@dancoombs
fix(types): fix v0.7 valid_until parsing to replace 0 with MAX
5e7f3d9
@dancoombs
fix(builder): fix raw txn sender submitter provider order
4970ee6
@andysim3d @dancoombs
fix: submitter should be used regardless use_submit_for_status's value
34db7e8
@andysim3d @dancoombs
style: check pr title with commitlint.
3287eb4
@andysim3d @dancoombs
feat: enable permissions for pr from forks.
cbdd0c5
@andysim3d @dancoombs
feat(better-error): change provider error cast to carry more context.
3a67f3d
@andysim3d @dancoombs
refactor: remove redundant code.
f0c4fce
@dancoombs
feat(pool): add da tracking to pool
0e7107b
@dancoombs
fix(pool): only ineligible if da tracking, always emit events
0ab743a
@dancoombs
feat(pool): reject UOs below configurable gas limit efficiency
d8292ea
@dancoombs
feat(pool): emit log when UO removed due to pool size
3b3014f
@dancoombs
refactor: refactor da gas provider/oracle interfaces
01cebb5
@dancoombs
refactor: use type erasure on types with lots of generics
2bbd1c2
@dancoombs
chore: rename da oracle to DAGasOracleType
fe607fb
@dancoombs
chore: update to rust 1.82
634af67
@codecov Codecov
Copy link

codecov bot commented Oct 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 44.51086% with 2785 lines in your changes missing coverage. Please review.

Project coverage is 58.73%. Comparing base (d547409) to head (e08d893).
Report is 56 commits behind head on main.

Files with missing lines Patch % Lines
crates/provider/src/alloy/entry_point/v0_7.rs 0.00% 339 Missing ⚠️
crates/provider/src/alloy/entry_point/v0_6.rs 0.00% 328 Missing ⚠️
crates/provider/src/alloy/da/mod.rs 0.00% 264 Missing ⚠️
crates/provider/src/alloy/evm.rs 45.11% 146 Missing ⚠️
crates/provider/src/alloy/da/local/bedrock.rs 0.00% 137 Missing ⚠️
crates/pool/src/task.rs 0.00% 128 Missing ⚠️
crates/provider/src/alloy/da/local/nitro.rs 0.00% 128 Missing ⚠️
crates/builder/src/task.rs 0.00% 115 Missing ⚠️
bin/rundler/src/cli/mod.rs 0.00% 96 Missing ⚠️
crates/provider/src/alloy/metrics.rs 0.00% 95 Missing ⚠️
... and 41 more
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
crates/builder/src/emit.rs 36.00% <100.00%> (ø)
crates/pool/src/mempool/mod.rs 100.00% <100.00%> (ø)
crates/pool/src/mempool/reputation.rs 85.25% <ø> (ø)
crates/provider/src/traits/entry_point.rs 100.00% <100.00%> (+40.00%) ⬆️
crates/provider/src/traits/evm.rs 100.00% <ø> (ø)
crates/provider/src/traits/test_utils.rs 100.00% <ø> (ø)
crates/rpc/src/admin.rs 0.00% <ø> (ø)
crates/rpc/src/debug.rs 0.00% <ø> (ø)
crates/rpc/src/eth/api.rs 70.11% <ø> (+0.44%) ⬆️
crates/rpc/src/eth/error.rs 0.00% <ø> (ø)
... and 105 more

... and 4 files with indirect coverage changes

Flag Coverage Δ
unit-tests 58.73% <44.51%> (+1.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <0.00%> (ø)
builder 63.37% <53.21%> (+2.79%) ⬆️
dev ∅ <ø> (∅)
pool 66.73% <77.23%> (+2.26%) ⬆️
provider 20.87% <8.06%> (+4.76%) ⬆️
rpc 25.87% <ø> (+0.42%) ⬆️
sim 76.65% <ø> (-1.89%) ⬇️
tasks ∅ <ø> (∅)
types 67.83% <ø> (+1.15%) ⬆️
utils 29.38% <ø> (+11.10%) ⬆️

@dancoombs dancoombs changed the title Rundler v0.4 chore: Rundler v0.4 Oct 19, 2024
0xfourzerofour
0xfourzerofour approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@0xfourzerofour 0xfourzerofour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty confident approving after all the smaller PR reads

@dancoombs dancoombs merged commit acde483 into main Oct 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andysim3d andysim3d andysim3d approved these changes

@0xfourzerofour 0xfourzerofour 0xfourzerofour approved these changes

@dphilipson dphilipson Awaiting requested review from dphilipson dphilipson is a code owner

@alex-miao alex-miao Awaiting requested review from alex-miao alex-miao is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dancoombs @andysim3d @0xfourzerofour