Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kms): do not require distributed locking when only using one kms key #475

Merged
merged 3 commits into from
Oct 20, 2023

Conversation

0xfourzerofour
Copy link
Collaborator

Closes #361

Proposed Changes

  • Change create conditional signer based on length of kms keys so that the kms_guard can be turned into an optional field and not created with only one key id

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #475 (ae65be4) into main (dc7a26c) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

Files Coverage Δ
crates/builder/src/signer/aws.rs 0.00% <0.00%> (ø)
Flag Coverage Δ
unit-tests 52.60% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <ø> (ø)
builder 47.67% <0.00%> (-0.15%) ⬇️
dev 0.00% <ø> (ø)
pool 59.92% <ø> (ø)
provider 1.33% <ø> (ø)
rpc 18.26% <ø> (ø)
sim 82.20% <ø> (ø)
tasks ∅ <ø> (∅)
types 93.56% <ø> (ø)
utils 7.20% <ø> (ø)

@0xfourzerofour 0xfourzerofour merged commit 68963c1 into main Oct 20, 2023
7 checks passed
@0xfourzerofour 0xfourzerofour deleted the josh/kms-redis branch October 20, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

builder: Avoid needing KMS+Redis key locking this if only a single KMS key id is provided to bundler
2 participants