Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(log): capture logs from the log crate to tracing subscriber #472

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

dancoombs
Copy link
Collaborator

Proposed Changes

  • Some dependencies we rely on use the log create, we should capture those logs to our tracing subscriber

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #472 (3c4a06a) into main (8592d35) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

Files Coverage Δ
bin/rundler/src/cli/tracing.rs 0.00% <0.00%> (ø)
Flag Coverage Δ
unit-tests 52.69% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <0.00%> (ø)
builder 47.98% <ø> (ø)
dev 0.00% <ø> (ø)
pool 59.92% <ø> (ø)
provider 1.33% <ø> (ø)
rpc 18.26% <ø> (ø)
sim 82.20% <ø> (ø)
tasks ∅ <ø> (∅)
types 93.56% <ø> (ø)
utils 7.20% <ø> (ø)

@dancoombs dancoombs merged commit 6b4a74c into main Oct 18, 2023
8 checks passed
@dancoombs dancoombs deleted the danc/capture-log branch October 18, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants