-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(polygon): remove dependency on gas station #384
Conversation
b245545
to
8629688
Compare
This looks reasonable as a polygon fee estimation replacement. I think we should move towards this method for all of our fee estimation and be able to configure this via a CLI flag. Maybe we get this merged to fix the polygon issue, and then file a ticket for a follow up that uses |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! A few comments inline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before we merge this, can you do a quick spot check that when you run a local node from this branch and hit staging you get similar if not equal values for rundler_maxPriorityFeePerGas
LGTM though, nice work!
Also, don't for get to rebase to 1 commit! |
@dancoombs Yeh that is how I have been testing it. Checking gas station and comparing values. There is some slight differences but I think it is due to gas station delay |
1d37272
to
1907927
Compare
[Closes] #377
Proposed Changes
eth_feeHistory
rpc api.