chore(metrics): improve pool/builder metrics/events #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dancoombs
force-pushed
the
danc/improve-metrics
branch
2 times, most recently
from
e39f252
to
18b681b
Compare
noam-alchemy
approved these changes
Aug 10, 2023
| @@ -130,6 +125,10 @@ where | |||
| } | |||
| } | |||
| for op in unmined_ops { | |||
| if op.entry_point != self.entry_point { | |||
There was a problem hiding this comment.
not in scope of this PR but is there an issue to measure unit test coverage on CI?
There was a problem hiding this comment.
Also adding a test for this specific case. @dphilipson I'm pretty sure this logic is correct but would like your eyes on it.
dancoombs
force-pushed
the
danc/improve-metrics
branch
from
18b681b
to
5aa1122
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some metrics to the pool and include simulation violation in the rejection event
Closes #281