feat(error): use unexpected error instead (#761)

.github/workflows/unit.yaml

@@ -21,7 +21,7 @@ jobs:
           submodules: 'recursive'
 
       - name: Install toolchain
-        uses: dtolnay/rust-toolchain@stable
+        uses: dtolnay/rust-toolchain@1.79.0
         with:
           components: llvm-tools-preview
 

crates/pool/src/server/local.rs

@@ -106,9 +106,14 @@ impl LocalPoolHandle {
                 response: send,
             })
             .await
-            .map_err(|_| anyhow::anyhow!("LocalPoolServer closed"))?;
-        recv.await
-            .map_err(|_| anyhow::anyhow!("LocalPoolServer closed"))?
+            .map_err(|_| {
+                error!("LocalPoolServer sender closed");
+                PoolError::UnexpectedResponse
+            })?;
+        recv.await.map_err(|_| {
+            error!("LocalPoolServer receiver closed");
+            PoolError::UnexpectedResponse
+        })?
     }
 }
 

crates/sim/src/gas/gas.rs

@@ -13,7 +13,7 @@
 
 use std::{cmp, fmt::Debug, sync::Arc};
 
-use anyhow::Context;
+use anyhow::{bail, Context};
 use ethers::types::U256;
 use rundler_provider::{EntryPoint, L1GasProvider, Provider};
 use rundler_types::{
@@ -84,6 +84,10 @@ pub async fn calc_required_pre_verification_gas<
         op.max_fee_per_gas(),
     );
 
+    if gas_price.is_zero() {
+        bail!("Gas price cannot be zero")
+    }
+
     let dynamic_gas = entry_point
         .calc_l1_gas(entry_point.address(), op.clone(), gas_price)
         .await?;

crates/sim/src/precheck.rs

@@ -408,7 +408,6 @@ where
     ) -> anyhow::Result<U256> {
         gas::calc_required_pre_verification_gas(&self.chain_spec, &self.entry_point, &op, base_fee)
             .await
-            .context("should calculate pre-verification gas")
     }
 }