Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #22[WIP]Crypto #32

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Issue #22[WIP]Crypto #32

wants to merge 2 commits into from

Conversation

dz85
Copy link
Contributor

@dz85 dz85 commented Dec 9, 2020

WillemJiang
WillemJiang reviewed Dec 12, 2020
View reviewed changes
apache/license/crypto.md
@@ -0,0 +1,216 @@
# 【WIP】标题：在 ASF 版本中使用密码学技术
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在PR上面标注 WIP就可以了，不需要在成稿上标注。

Copy link
Contributor Author

@dz85 dz85 Dec 31, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的，了解了。

apache/license/crypto.md
# 【WIP】标题：在 ASF 版本中使用密码学技术

- [【WIP】标题：在 ASF 版本中使用密码学技术](#wip标题在-asf-版本中使用密码学技术)
- [本页更新通知¶](#本页更新通知)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¶ 这个符号有什么其他作用吗， 感觉是复制文本的时候加上的，建议删除。

Copy link
Contributor Author

@dz85 dz85 Dec 31, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

原文中，该符号的原意应该是特指本段，是具备实际意义的，所以需要保留。
可参见：https://www.w3.org/wiki/Common_HTML_entities_used_for_typography

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看了原文，这个符号应该没什么含义，这个是某些博客系统生成的锚点，为了能够分享复制链接的时候快速定位到这个段

比如这种博客系统 https://skywalking.apache.org/blog/2020-12-03-obs-service-mesh-with-sw-and-als/#how-it-works 的锚点用的就是这个符号
image

和这种符号 § 也有，建议还是删除吧

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是的，这样的锚点有助于读者分享某一个文章的片段，具有实际功能，而且w3c规范里也对该字符赋予了具体的含义；因此该符号链接同时具备功能性和语义，建议保留。

@dz85 dz85 changed the title Crypto [WIP]Crypto Dec 31, 2020
@dz85 dz85 changed the title [WIP]Crypto Issue #22[WIP]Crypto Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillemJiang WillemJiang WillemJiang left review comments

@kezhenxu94 kezhenxu94 kezhenxu94 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dz85 @WillemJiang @kezhenxu94