Skip to content

Commit

Permalink
chore: Use shiny's Makefile to allow for test commands to change over…
Browse files Browse the repository at this point in the history
… time (narwhals-dev#1161)

* Use shiny's Makefile to allow for test commands to change over time

Related: 
* posit-dev/py-shiny#1729
* posit-dev/py-shiny#1731

* Remove white space

* Update step name
  • Loading branch information
schloerke authored and akmalsoliev committed Oct 15, 2024
1 parent e1a15e2 commit 08e3a15
Showing 1 changed file with 5 additions and 9 deletions.
14 changes: 5 additions & 9 deletions .github/workflows/downstream_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -113,22 +113,18 @@ jobs:
- name: install-basics
run: uv pip install --upgrade tox virtualenv setuptools --system
- name: install-shiny-dev
env:
UV_SYSTEM_PYTHON: 1
run: |
cd py-shiny
uv pip install -e ".[dev,test]" --system
make narwhals-install-shiny
- name: install-narwhals-dev
run: |
uv pip uninstall narwhals --system
uv pip install -e . --system
- name: show-deps
run: uv pip freeze
- name: Run pytest
run: |
cd py-shiny
python tests/pytest/asyncio_prevent.py
pytest
- name: Run mypy
- name: Run `make narwhals-test-integration`
run: |
cd py-shiny
uv pip install mypy --system
mypy shiny
make narwhals-test-integration

0 comments on commit 08e3a15

Please sign in to comment.