Improve Streams Throttle. Log errors, improve tests, and add supervisor strategy support #6886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
requested changes
Aug 17, 2023
| @@ -46,66 +49,101 @@ private static ByteString GenerateByteString(int length) | |||
| return ByteString.FromBytes(bytes); | |||
| } | |||
|
|
|||
| [Fact(DisplayName = "Throttle with delegate calculateCost must resume when delegate throws")] | |||
| @@ -1893,7 +1893,7 @@ public SplitAfterMergeBack(IFlow<TOut, TMat> self, Func<TOut, bool> predicate, S | |||
| int maximumBurst, ThrottleMode mode) | |||
| { | |||
| if (elements <= 0) throw new ArgumentException("Throttle elements must be > 0", nameof(elements)); | |||
| if (per == TimeSpan.Zero) throw new ArgumentException("Throttle per timeout must not be zero", nameof(per)); | |||
| if (per <= TimeSpan.Zero) throw new ArgumentException("Throttle per timeout must not be less than or equal to zero", nameof(per)); | |||
| else | ||
| { | ||
| if (_enforcing) | ||
| throw new OverflowException("Maximum throttle throughput exceeded."); |
There was a problem hiding this comment.
Problem: if we're enforcing, do we need to fail regardless of what the supervision strategy says?
There was a problem hiding this comment.
I think it should fail regardless, I'll change the code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6406
Changes