feat: updateTimestampOffset #1102
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvlugter
reviewed
Dec 20, 2023
| * This can be useful if the projection was stuck with errors on a specific offset and should skip | ||
| * that offset and continue with next. | ||
| * | ||
| * Another use case is to populate the offset store with know starting points when enabling change events |
There was a problem hiding this comment.
Suggested change
| * Another use case is to populate the offset store with know starting points when enabling change events | |
| * Another use case is to populate the offset store with known starting points when enabling change events |
johanandren
reviewed
Dec 20, 2023
| } | ||
|
|
||
| retry(() => askSetTimestampOffset()) | ||
| } |
There was a problem hiding this comment.
How would one handling starting a new projection from the offsets, hold back the consumer until the response comes back from this API, because it would start consuming from start as soon as it has started executing, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just an idea so far...
For the Durable State change events it's possible that you start out with ordinary Durable State and then enable change events later. Meaning that there will missing events and offsets for earlier sequence numbers (revisions). The offset validation will reject them and the projection will be stuck.
One way would be to populate the offset store with known "starting points" via the projection management api.
In general, we are lacking projection management for timestamp offsets, because they are not a single value.