Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/grpc transcoding #1834

Open
wants to merge 54 commits into
base: main
Choose a base branch
from
Open

Conversation

GreyPlane
Copy link

inherit the work from #1583 since it's likely abandoned

@lightbend-cla-validator

Hi @WayneWang12,

Thank you for your contribution! We really value the time you've taken to put this together.

We see that you have signed the Lightbend Contributors License Agreement before, however, the CLA has changed since you last signed it.
Please review the new CLA and sign it before we proceed with reviewing this pull request:

https://www.lightbend.com/contribute/cla

@lightbend-cla-validator

Hi @WayneWang12,

Thank you for your contribution! We really value the time you've taken to put this together.

We see that you have signed the Lightbend Contributors License Agreement before, however, the CLA has changed since you last signed it.
Please review the new CLA and sign it before we proceed with reviewing this pull request:

https://www.lightbend.com/contribute/cla

@GreyPlane
Copy link
Author

weird blocking issue scalapb/ScalaPB#1583

@lightbend-cla-validator

Hi @WayneWang12,

Thank you for your contribution! We really value the time you've taken to put this together.

We see that you have signed the Lightbend Contributors License Agreement before, however, the CLA has changed since you last signed it.
Please review the new CLA and sign it before we proceed with reviewing this pull request:

https://www.lightbend.com/contribute/cla

2 similar comments
@lightbend-cla-validator
Copy link

Hi @WayneWang12,

Thank you for your contribution! We really value the time you've taken to put this together.

We see that you have signed the Lightbend Contributors License Agreement before, however, the CLA has changed since you last signed it.
Please review the new CLA and sign it before we proceed with reviewing this pull request:

https://www.lightbend.com/contribute/cla

@lightbend-cla-validator
Copy link

Hi @WayneWang12,

Thank you for your contribution! We really value the time you've taken to put this together.

We see that you have signed the Lightbend Contributors License Agreement before, however, the CLA has changed since you last signed it.
Please review the new CLA and sign it before we proceed with reviewing this pull request:

https://www.lightbend.com/contribute/cla

@GreyPlane
Copy link
Author

I think this is ready to go, the implementation itself is stable enough to review, while I'm still working on adding more tests and documentations.

@GreyPlane GreyPlane marked this pull request as ready for review October 1, 2023 06:54
@johanandren
Copy link
Member

Nice to see work here but just so you know: we don't quite have the bandwidth to properly keep up with reviewing this PR right now, so don't think of it as something that will get merged soon.

@GreyPlane
Copy link
Author

Nice to see work here but just so you know: we don't quite have the bandwidth to properly keep up with reviewing this PR right now, so don't think of it as something that will get merged soon.

That's understandable, just knowing you guys are interested on this is enough.

@lightbend-cla-validator
Copy link

Hi @WayneWang12,

Thank you for your contribution! We really value the time you've taken to put this together.

We see that you have signed the Lightbend Contributors License Agreement before, however, the CLA has changed since you last signed it.
Please review the new CLA and sign it before we proceed with reviewing this pull request:

https://www.lightbend.com/contribute/cla

GreyPlane and others added 26 commits February 19, 2024 14:20
* guava dependency to 32.0.1 to address CVE-2023-2976
* protobuf-java 3.24.0, which is what grpc-protobuf:1.58.0 brings in
* plugin-tester-java wasn't setting protoc version when inside sbt
* workaround for ScalaPB EnumType issue, because of ScalaPB issue 1557
* not sure, but parallelExecution false
* tests with invalid endpoints not working
* Don't use assert
* bump: sbt-paradox-dependencies 0.2.4
  * cycle between grpc-core and grpc-util
* and Akka HTTP 10.6.0
* docs: gradle config that works from quickstarts
* Simplify plugin tester gradle setup
@GreyPlane
Copy link
Author

  • Gradle plugin wouldn't generate ScalaPB classes for library protos, which causes generated Scala proto classes(user side) failed to use HTTP transcoding related proto classes, I've added these into protoSrc, but not very confident it's the right thing to do.
  • Scripted test reported huge duplicated generated proto classes, mainly from google.api.*, which I haven't figure out how to deal with.

I think these two are the remaining blocker, but it's hard to solve due I'm lacking relative experience, so any help or suggestion was appreciate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants