feat: Ignore specific errors for given pods #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@able8 any chance of getting this in? |
able8
reviewed
Dec 6, 2023
able8
reviewed
Dec 6, 2023
|
Hi @nikup @ventsislav-georgiev, thank you for contributing. I left 2 comments. |
nikup
force-pushed
the
feat-support-ignored-error-for-pod-prefix
branch
from
47ce53e
to
76c605e
Compare
|
@able8 Comments were addressed long time ago, but I just send a CLA via email - if you can take a look and merge this before it turns a year old :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for ignoring a specific restart error for a specific type of pod.
Example: We have a
gke-metrics-agentthat sometimes can't start because ofFailed to run the service: failed to start extensions: listen tcp 127.0.0.1:8203: bind: address already in use. With the current implementation we can ignore that by adding