Skip to content
This repository has been archived by the owner on Feb 13, 2024. It is now read-only.

feat(startup): Improve startup when database is not erased #62

Merged
merged 12 commits into from
Nov 3, 2023

Conversation

Mitsichury
Copy link
Contributor

No description provided.

@Mitsichury Mitsichury marked this pull request as draft October 18, 2023 03:49
@Mitsichury Mitsichury changed the title Feat/bakcup last block feat(startup): Improve startup when database is not erased Oct 18, 2023
@Mitsichury Mitsichury marked this pull request as ready for review October 18, 2023 06:48
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, only found a typo.

src/client/Web3RegistryClient.ts Outdated Show resolved Hide resolved
@@ -1,14 +1,19 @@
import { Peers } from './../peer/Peers.js';
import { Web3RegistryClient } from './Web3RegistryClient.js';

export function getRegistry(conf: any, peers: Peers): Web3RegistryClient | null {
export async function getRegistry(conf: any, peers: Peers, previsousChainObserved: number[]): Promise<Web3RegistryClient | null> {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export async function getRegistry(conf: any, peers: Peers, previsousChainObserved: number[]): Promise<Web3RegistryClient | null> {
export async function getRegistry(conf: any, peers: Peers, previousChainObserved: number[]): Promise<Web3RegistryClient | null> {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted thank you :)

@Mitsichury Mitsichury merged commit bfef09d into main Nov 3, 2023
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant