This repository has been archived by the owner on Feb 13, 2024. It is now read-only.
feat(providers): Return http error when network is unsupported #44 #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mitsichury
changed the title
Mitsichury
changed the title
dmosites
suggested changes
Jul 27, 2023
src/client/getProviderUrl.ts
Outdated
| @@ -0,0 +1,30 @@ | |||
| const hostByChainId: Record<number, string> = | |||
There was a problem hiding this comment.
Recommend using apiUrls from @airswap/constants for these.
https://github.com/airswap/airswap-protocols/blob/develop/tools/constants/index.ts#L85
There was a problem hiding this comment.
using lib and fallback now, thanks :)
There was a problem hiding this comment.
Please remove the fallback as AirSwap only supports networks found in apiUrls.
package.json
Outdated
| @@ -16,7 +16,7 @@ | |||
| "type": "module", | |||
| "license": "MIT", | |||
| "dependencies": { | |||
| "@airswap/libraries": "4.0.10", | |||
| "@airswap/libraries": "4.0.13", | |||
src/client/getProviderUrl.ts
Outdated
| if (!host) { | ||
| throw new Error("Unknown chain ID"); | ||
| } | ||
| return `https://${host}/${apiKey}`; |
There was a problem hiding this comment.
Only append apiKey if host URL includes infura.io/v3.
Mitsichury
force-pushed
the
fix/unsup_network
branch
from
2bcad2e
to
23342c7
Compare
dmosites
approved these changes
Aug 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.