Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use EIP712s hashTypedData functions #1306

Closed
wants to merge 1 commit into from
Closed

Use EIP712s hashTypedData functions #1306

wants to merge 1 commit into from

Conversation

k06a
Copy link

@k06a k06a commented Apr 25, 2024

No description provided.

@openzeppelin-code OpenZeppelin Code
Copy link

Use EIP712s hashTypedData functions

Generated at commit: 556818daad2788898268def2dac141f5c0690ea8

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 1
1
0
7
24
33
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@dmosites
Copy link
Contributor

Thanks. This could also be used on SwapERC20.sol:L260?
https://github.com/airswap/airswap-protocols/pull/1306/files#diff-a1ad63b6dfc142aa0e9d5894dd4d55c81fadc2bd1a98318b964be3c84c91aae7L260

@k06a
Copy link
Author

k06a commented May 17, 2024

@dmosites true

@dmosites
Copy link
Contributor

Implemented in #1318 thank you @k06a

@dmosites dmosites closed this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k06a @dmosites