Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue1140 #225

Merged
merged 8 commits into from
Jul 22, 2024
Merged

Issue1140 #225

merged 8 commits into from
Jul 22, 2024

Conversation

remochristen
Copy link
Contributor

No description provided.

salome-eriksson
salome-eriksson reviewed Jul 16, 2024
View reviewed changes
Copy link
Contributor

@salome-eriksson salome-eriksson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks sound to me; my only two remarks are about comments.

src/search/search_algorithms/eager_search.cc Outdated Show resolved Hide resolved
src/search/search_algorithms/eager_search.cc Show resolved Hide resolved
@remochristen remochristen marked this pull request as ready for review July 18, 2024 10:20
@remochristen remochristen merged commit e408c7d into aibasel:main Jul 22, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorianPommerening FlorianPommerening FlorianPommerening left review comments

@maltehelmert maltehelmert maltehelmert left review comments

@salome-eriksson salome-eriksson salome-eriksson left review comments

@SimonDold SimonDold SimonDold left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@remochristen @FlorianPommerening @maltehelmert @salome-eriksson @SimonDold