replace tl::optional with std::optional #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misc/style/run-clang-tidy.py
Outdated
| # Include all non-system headers (.*) except the ones from search/ext/. | ||
| "-header-filter=.*,-tree.hh,-tree_util.hh", | ||
| # Include all non-system headers. | ||
| "-header-filter=.*", |
There was a problem hiding this comment.
Shouldn't these two lines now be unnecessary? Or is the default to ignore all headers (which would be a weird default)?
There was a problem hiding this comment.
I broke something in evaluator.h to test this and ran this with and without the parameter. With the parameter I got the same warning 84 times (once for every path on which the header is included), without the line, I got the warning once.
So the parameter causes a difference in what is checked but since the error still was reported, I'd say it is better to remove the lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.