Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix] change default requirements to production requirements #80

Merged
merged 8 commits into from
Sep 23, 2022

Conversation

Croydon-Brixton
Copy link
Collaborator

@Croydon-Brixton Croydon-Brixton commented Jul 13, 2022

Todo:

  • Fix dependency versions in requirements.txt
  • Clean up requirements folder (should only have environment.yaml and production reqirements)
  • Verify correct installation with fixed dependencies

@herbiebradley
Copy link
Member

Feel free to merge - we're figuring out the right dependencies with rasterio in #81. I also want to include matplotlib and seaborn in the requirements.txt, but probably simpler to include that in the above PR rather than this one.

@Croydon-Brixton Croydon-Brixton changed the base branch from main to staging September 23, 2022 14:20
@Croydon-Brixton
Copy link
Collaborator Author

Croydon-Brixton commented Sep 23, 2022

Fixed binder and requirements jungle 😉

✅ Requirement pins were tested successfully, both on MacOS & Ubuntu
✅ Resolves #83

Copy link
Member

@rdnfn rdnfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Simon for all this work! Very good to have all of these requirements updated. I know this stuff takes a lot of work, so your contribution is much appreciated!

@Croydon-Brixton Croydon-Brixton merged commit 3ce2622 into staging Sep 23, 2022
@Croydon-Brixton Croydon-Brixton deleted the Croydon-Brixton-patch-1 branch September 23, 2022 14:31
@Croydon-Brixton Croydon-Brixton restored the Croydon-Brixton-patch-1 branch September 23, 2022 14:54
@Croydon-Brixton Croydon-Brixton deleted the Croydon-Brixton-patch-1 branch September 23, 2022 16:10
@Croydon-Brixton Croydon-Brixton restored the Croydon-Brixton-patch-1 branch September 23, 2022 16:10
@Croydon-Brixton Croydon-Brixton deleted the Croydon-Brixton-patch-1 branch September 23, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants