Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create universal mac app #259

Merged
merged 7 commits into from
Jun 26, 2024
Merged

Create universal mac app #259

merged 7 commits into from
Jun 26, 2024

Conversation

steveoh
Copy link
Member

@steveoh steveoh commented Jun 18, 2024

refs #255

I'm not 100% sure if this is how this is supposed to be implemented as the docs are a bit vague. I was hoping we could try it between your and my computer.

your app should work flawlessly once you update the target architecture to arm64.

I'm not sure if we need to specifically build two apps and call merge somehow or if forge will do it just because? It's all a little unclear based on the docs and I can't find any examples.

You will need to ship two versions of your app: one for x64 (Intel Mac) and one for arm64 (Apple Silicon). The good news is that electron-packager, electron-rebuild and electron-forge already support targeting the arm64 architecture. As long as you're running the latest versions of those packages, your app should work flawlessly once you update the target architecture to arm64.

Update: This package is now available at @electron/universal. You can use it to merge two packaged x64 and arm64 apps into a single binary.

@steveoh steveoh requested a review from stdavis June 18, 2024 17:26
@github-actions github-actions bot added the bug Something isn't working label Jun 18, 2024
@stdavis
Copy link
Member

stdavis commented Jun 18, 2024

Ya, I'm not sure how installing @electron/universal will somehow let forge know that we want to us it. How do you want me to test this out? It runs in development locally without any issues, but so did the last version. Running npm run make fails with a code signing error.

@steveoh
Copy link
Member Author

steveoh commented Jun 18, 2024

Ya, I'm not sure how installing @electron/universal will somehow let forge know that we want to use it.

The docs make it sound magical but you're right, it probably needs some configuration or post processing?

How do you want me to test this out? It runs in development locally without any issues, but so did the last version. Running npm run make fails with a code signing error.

We might need to make the code signing work locally with the certs etc or create a test app and borrow our CI pipeline to not disrupt current production?

@steveoh steveoh marked this pull request as ready for review June 26, 2024 20:39
@steveoh steveoh merged commit 6f4c75c into main Jun 26, 2024
3 checks passed
@steveoh steveoh deleted the fix/universal-mac-apps branch June 26, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants