Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: add depth option #37

Open
wants to merge 3 commits into
base: gh-pages
Choose a base branch
from

Conversation

MathieuDuponchelle
Copy link

Had to make the css recursive so that nested sub levels contrast with their parent consistently

Christian Savoie and others added 2 commits June 20, 2017 14:42
Fix text shifting by 1 pixel on hover
Add Unit test
@MathieuDuponchelle
Copy link
Author

@afeld , care to give this a quick look ? Been using that for some time with no problems

@sasanikolic90
Copy link

Hi @MathieuDuponchelle, thanks for your work, that looks great!
One question tho, do you think the check in getTopLevel() for $headings.length > 1 is needed? In this case, where we want to display the full table of content, this does not display the H1 for example.

H1
- H2
- H2
- - H3
- - - H4
- H2

@MathieuDuponchelle
Copy link
Author

@sasanikolic90 , I suppose you could add an option for that, that's not really related to this PR is it? In my case I do want to ignore the top level when it only has a single item fwiw

@MathieuDuponchelle
Copy link
Author

ping @afeld btw

@sasanikolic90
Copy link

I created a new rebased MR here: #52

@MathieuDuponchelle
Copy link
Author

@sasanikolic90 , would be nice if you could preserve authorship ;)

@sasanikolic90
Copy link

@MathieuDuponchelle yeah, sorry about that, but not sure how since these changes did not apply anymore.

@MathieuDuponchelle
Copy link
Author

git commit --amend --author=XXX comes to mind :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants