fix: TOOLS-2978 & TOOLS-2977 federal edition in build col #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-spiker
changed the title
info Edition calls from server will not have true / false or CE / EE
|
Verified the behaviour with
cc @sunilvirus |
|
Ok. That’s nice.
Let’s simplify the code like we discussed yesterday.
…On Tue, Oct 22, 2024 at 10:39 PM Akash Chandra ***@***.***> wrote:
Verified the behaviour with
- aerospike:4.4.0.6
- aerospike:4.9.0.8
- aerospike:ee-5.6.0.5
- aerospike:ee-6.2.0.2
- aerospike:ce-6.2.0.2
- aerospike:ce-7.1.0.3
cc @sunilvirus <https://github.com/sunilvirus>
—
Reply to this email directly, view it on GitHub
<#315 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFQJM4GSZZ3EGHD5FK4LZDZ44ZBHAVCNFSM6AAAAABQL3UHFCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZQHE2TINZUHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@sunilvirus Already done based on our discussion. Kindly review. |
sunilvirus
reviewed
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build column should have F- for Federal edition
Fixes: TOOLS-2977 & TOOLS-2977
Simplifying the logic, Info Edition Calls to Server will not have true / false or CE / EE. Valid responses are