AER-3128 Animal housing less animal type based #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basic housing is now based on animal housing category instead of the animal type. This is due to some animal types having multiple basic animal housing categories. Similarly, additional system factors are now based on animal housing category instead of the animal type. This is due to having different reduction factors for some animal housing + additional system combinations. Implementations will have to be adjusted accordingly.
Doesn't matter too much as we're not directly using this in test cases, but makes more sense.
JornC
approved these changes
Aug 7, 2024
source/imaer-gml/src/test/java/nl/overheid/aerius/test/TestValidationAndEmissionHelper.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic housing is now based on animal housing category instead of the animal type. This is due to some animal types having multiple basic animal housing categories. Similarly, additional system factors are now based on animal housing category instead of the animal type. This is due to having different reduction factors for some animal housing + additional system combinations. Implementations will have to be adjusted accordingly.