Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed PR github action to fail when test fails #278

Merged
merged 4 commits into from
Jun 7, 2024
Merged

Changed PR github action to fail when test fails #278

merged 4 commits into from
Jun 7, 2024

Commits on May 30, 2024

  1. Changed PR github action to fail when test fails 

    Release already fails if this is the case, so makes more sense to fail when a PR introduces new failing tests.
(noticed some tests failing, thought it already worked this way)
    @BertScholten
    BertScholten committed May 30, 2024
    Configuration menu
    Copy the full SHA
    1b928e5 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. Adjusted workflow definitions to new version 

    Defaults work better now (JDK default 17, ignore test defaults also make more sense)
    @BertScholten
    BertScholten committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    fc7def0 View commit details
    Browse the repository at this point in the history

  2. Adding guaranteed failing test to check if job actually fails

    @BertScholten
    BertScholten committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    298735a View commit details
    Browse the repository at this point in the history

  3. Revert "Adding guaranteed failing test to check if job actually fails" 

    This reverts commit 298735a.
    @BertScholten
    BertScholten committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    c8b329f View commit details
    Browse the repository at this point in the history