Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use curl and not wget by default to avoid LetsEncrypt SSL handshake for freemarker and boot JDK downloads #2742

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

sxa
Copy link
Member

@sxa sxa commented Oct 5, 2021

This is impacting the OpenJ9 buids which use freemarker and I believe curl will work on the affected systems (or at least many of them!) as it uses it's own CA store.

FYI @AdamBrousseau

Signed-off-by: Stewart X Addison [email protected]

@sxa
Copy link
Member Author

sxa commented Oct 5, 2021

VPC run to check this (along with adoptium/infrastructure#2339 which is failing with the CentOS site)

@AdamBrousseau
Copy link
Contributor

I drafted ibmruntimes/ci-jenkins-pipelines#28 and ibmruntimes#3 which are untested at the moment. Since the only remaining platform that requires freemarker is riscv, @pshipton was ok with breaking it until cmake support was ready. Alternatively we could change the if to only download on that platform. I think the ideal check would be "if not cmake" or "if uma" but I'm unsure what info we have at the time of the check/download.

@pshipton
Copy link
Contributor

pshipton commented Oct 5, 2021

ok with breaking it until cmake support was ready

Not what I meant. I meant I'm ok to break it for a week or two while we look for a workaround. Not sure when cmake will be ready, that might be too long.

@sxa sxa changed the title Use curl and not wget by default to avoid LetsEncrypt SSL handshake for freemarker download Use curl and not wget by default to avoid LetsEncrypt SSL handshake for freemarker and boot JDK downloads Oct 6, 2021
@sxa sxa requested a review from karianna October 6, 2021 07:00
@sxa
Copy link
Member Author

sxa commented Oct 6, 2021

run tests

Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants