-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use curl and not wget by default to avoid LetsEncrypt SSL handshake for freemarker and boot JDK downloads #2742
Conversation
VPC run to check this (along with adoptium/infrastructure#2339 which is failing with the CentOS site) |
I drafted ibmruntimes/ci-jenkins-pipelines#28 and ibmruntimes#3 which are untested at the moment. Since the only remaining platform that requires freemarker is riscv, @pshipton was ok with breaking it until cmake support was ready. Alternatively we could change the |
Not what I meant. I meant I'm ok to break it for a week or two while we look for a workaround. Not sure when cmake will be ready, that might be too long. |
63686ab
to
7934ed5
Compare
ecffe83
to
038e598
Compare
…ailures Signed-off-by: Stewart X Addison <[email protected]>
038e598
to
31e0a8b
Compare
run tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is impacting the OpenJ9 buids which use freemarker and I believe
curl
will work on the affected systems (or at least many of them!) as it uses it's own CA store.FYI @AdamBrousseau
Signed-off-by: Stewart X Addison [email protected]