Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump fedora from 36 to 40 in /linux/jre/redhat/src/main/packaging #878

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 26, 2024

Bumps fedora from 36 to 40.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps fedora from 36 to 40.

---
updated-dependencies:
- dependency-name: fedora
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file docker Pull requests that update Docker code labels Apr 26, 2024
@judovana
Copy link

39 would be enough, but should be done

@gdams
Copy link
Member

gdams commented Apr 29, 2024

Seems that the newer version of wget doesn't support Unknown progress type 'dot:mega'

@judovana
Copy link

Is there option to repalce afected wgets by curl?

@gdams
Copy link
Member

gdams commented Apr 29, 2024

Is there option to repalce afected wgets by curl?

yeah feel free to raise a PR, we need to change all the instances of this code that installs gosu. https://github.com/adoptium/installer/blob/5cfd4548dcfc2960fc6232b9bdf278fa201211a1/linux/jdk/redhat/src/main/packaging/Dockerfile#L13C1-L18C24

@judovana
Copy link

judovana commented Apr 29, 2024 via email

@judovana
Copy link

Tehn maybe --progress=dot -e dotbytes=1M ? But I need to doubel check it on f40 first

@gdams
Copy link
Member

gdams commented Apr 29, 2024

Looking at the gosu docs the other super simple approach is to just do COPY --from=tianon/gosu /gosu /usr/local/bin/

@judovana
Copy link

Tehn maybe --progress=dot -e dotbytes=1M ? But I need to doubel check it on f40 first

on f40

# wget "https://cdn.jsdelivr.net/musescore/v4.2.1/MuseScore-4.2.1.240230938-x86_64.AppImage"  --progress=dot -e dotbytes=1M
Progress type 'dot' ignored. It is not implemented yet
Unknown option 'dotbytes'

@judovana
Copy link

jsut for record it is wget2-wget-2.1.0-8.fc40.x86_64 x wget-1.21.4-1.fc38.x86_64 :(

@judovana
Copy link

judovana commented Apr 29, 2024

Note that the
wget "https://cdn.jsdelivr.net/musescore/v4.2.1/MuseScore-4.2.1.240230938-x86_64.AppImage" --progress=dot
is working, and is working much better then with wget1

@gdams
Copy link
Member

gdams commented Apr 29, 2024

Note that the wget "https://cdn.jsdelivr.net/musescore/v4.2.1/MuseScore-4.2.1.240230938-x86_64.AppImage" --progress=dot is working, and is working much better then with wget1

okay so do I want to dnf install wget2?

@judovana
Copy link

Note that the wget "https://cdn.jsdelivr.net/musescore/v4.2.1/MuseScore-4.2.1.240230938-x86_64.AppImage" --progress=dot is working, and is working much better then with wget1

okay so do I want to dnf install wget2?

Unluckily no. And definitely do not try to install wget1. I was jsut highlighting that a rework of wget - wget2, made it to stable fedora release.

I thinnk the best change would be to use just --progress=dot instead of --progress=dot:mega

On wget1 the --progress=dot was nearly unusable. on wget2 its much better. And if the code would be used in older fedora, it will at least somehow work.

@gdams
Copy link
Member

gdams commented Apr 30, 2024

--progress=dot

I'm seeing this:

wget2 google.com --progress=dot
Progress type 'dot' ignored. It is not implemented yet

I think I'm going to opt for the docker option as it's simpler for us:

COPY --from=tianon/gosu /gosu /usr/local/bin/

@gdams gdams force-pushed the dependabot/docker/linux/jre/redhat/src/main/packaging/fedora-40 branch from 065c4ce to 5bc6980 Compare April 30, 2024 08:29
@gdams gdams force-pushed the dependabot/docker/linux/jre/redhat/src/main/packaging/fedora-40 branch from 5bc6980 to d38fad3 Compare April 30, 2024 08:33
@judovana
Copy link

I'm container dummy, but the COPY --from=tianon/gosu /gosu /usr/local/bin/ means that the download must be locally enabled in som local cache. So If anybody do not know what to downlaod, they can not reuse.

@gdams
Copy link
Member

gdams commented Apr 30, 2024

I'm container dummy, but the COPY --from=tianon/gosu /gosu /usr/local/bin/ means that the download must be locally enabled in som local cache. So If anybody do not know what to downlaod, they can not reuse.

no it copies it from the upstream published goso docker image (which has already had the same gpg checks as part of it's build so it's safe to pull)

@judovana
Copy link

--progress=dot

I'm seeing this:

wget2 google.com --progress=dot
Progress type 'dot' ignored. It is not implemented yet

Right. but it works, and progress is nicely written. The dot was to work for wget1.
Maybe to drop --progress atr all?

@judovana
Copy link

Ah. Ii did not know that constructy. TYVM! Looks awesome then.

Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gdams gdams merged commit 6597ba7 into master Apr 30, 2024
59 checks passed
@gdams gdams deleted the dependabot/docker/linux/jre/redhat/src/main/packaging/fedora-40 branch April 30, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file docker Pull requests that update Docker code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants