Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to change output msi filename #857

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

jmjaffe37
Copy link
Contributor

@jmjaffe37 jmjaffe37 commented Apr 18, 2024

Allows vendors to set custom filenames for MSIs and related files by setting the OUTPUT_BASE_FILENAME environment variable

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.

If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.

If the code freeze is over you can remove this block by commenting /thaw.

@d3r3kk d3r3kk requested review from karianna and gdams April 18, 2024 18:51
@gdams
Copy link
Member

gdams commented Apr 18, 2024

/merge

Copy link

Approval to merge during the lockdown cycle

Please can two Adoptium PMC members comment /approve?

@tellison
Copy link
Contributor

/approve

1 similar comment
@karianna
Copy link
Contributor

/approve

@github-actions github-actions bot dismissed their stale review April 19, 2024 05:34

Thank you @tellison and @karianna for your approvals, this pull request is now approved to merge during release.

@karianna karianna merged commit fccf367 into adoptium:master Apr 19, 2024
7 checks passed
@jmjaffe37 jmjaffe37 deleted the jmj/fix_name branch April 19, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants