Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer updates for JDK20 for July 2023 release #701

Conversation

adamfarley
Copy link
Contributor

Styled after the April PR

@adamfarley adamfarley self-assigned this Jul 26, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.

If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.

If the code freeze is over you can remove this block by commenting /thaw.

Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiekang
Copy link
Contributor

jiekang commented Jul 26, 2023

Debian failing relevant log:

# Download and verify checksum of JRE
wget --progress=dot:mega -O jre.tar.gz https://github.com/adoptium/temurin20-binaries/releases/download/jdk-20.0.1%2B9/OpenJDK20U-jre_x64_linux_hotspot_20.0.2_9.tar.gz
Resolving github.com (github.com)... 140.82.113.4
Connecting to github.com (github.com)|140.82.113.4|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
make[1]: Leaving directory '/home/builder/workspace/packaging'
2023-07-26 12:11:12 ERROR 404: Not Found.

@adamfarley adamfarley force-pushed the jdk-20.0.2+9_installer_updates_for_July_2023_release branch from fccf3f6 to 9baf22c Compare July 26, 2023 13:47
@gdams
Copy link
Member

gdams commented Jul 26, 2023

/merge

@github-actions
Copy link

Approval to merge during the lockdown cycle

Please can two Adoptium PMC members comment /approve?

@gdams
Copy link
Member

gdams commented Jul 26, 2023

/approve

@gdams gdams enabled auto-merge (squash) July 26, 2023 14:08
@smlambert
Copy link
Contributor

/approve

@github-actions github-actions bot dismissed their stale review July 26, 2023 14:08

Thank you @gdams and @smlambert for your approvals, this pull request is now approved to merge during release.

@gdams gdams merged commit fa1d05a into adoptium:master Jul 26, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants