Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unixPB: adds roles xcode_offline and brew to Unix_Playbook #3417

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mahdipub
Copy link

The new Xcode_offline role will install xcode from an offline copy in /files dire. The brew role also will install brew on macos. Both rely on installing python on mac machine in advance.

Checklist

@karianna
Copy link
Contributor

karianna commented Mar 2, 2024

@mahdipub linter failures.

@mahdipub
Copy link
Author

mahdipub commented Mar 5, 2024

@mahdipub linter failures.

Seems all resolved now.

@karianna
Copy link
Contributor

karianna commented Mar 7, 2024

@mahdipub Ansible linter fixes needed by the looks.

@mahdipub
Copy link
Author

@mahdipub Ansible linter fixes needed by the looks.

Lint removed. Could you please try again?

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.

If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.

If the code freeze is over you can remove this block by commenting /thaw.

The new Xcode_offline role will install xcode from an offline copy in /files dire. The brew role also will install brew on macos. Both rely on installing python on mac machine in advance.
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure we already have scripts that install brew.

Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small suggestions

@gdams
Copy link
Member

gdams commented Jul 3, 2024

I might be missing something but the current roles already support this.

- name: Check for /tmp/Xcode_15.0.1.xip
stat:
path: /tmp/Xcode_15.0.1.xip
register: xcode15_0_1_xip

checks for the xcode.xip file to see if it exists already in the tmp directory before attempting to fetch it from the Azure Blob store?

@mahdipub
Copy link
Author

mahdipub commented Jul 3, 2024

I might be missing something but the current roles already support this.

- name: Check for /tmp/Xcode_15.0.1.xip
stat:
path: /tmp/Xcode_15.0.1.xip
register: xcode15_0_1_xip

checks for the xcode.xip file to see if it exists already in the tmp directory before attempting to fetch it from the Azure Blob store?

This PR, meant to support wider range of xcode version and architecture. If we decided to merge this PR, it might be better to remove the one you mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants