-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Add miro infrastructure map to Docs #2995
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.
If this pull request needs to be merged during the release cycle then please comment /merge
and a PMC member will be able to remove the block.
If the code freeze is over you can remove this block by commenting /thaw
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you export these at the same resolution in .gif
format instead of .pdf
? I suspect the total size will be quite a bit smaller for this sort of image (Currently this will add about 1Mb to the repository which only has about 5½Mb in it which isn't a deal-breaker but it would be nice to avoid it)
Also, please try to avoid creating PR branches in the upstream infrastructure repository - use your own fork.
/thaw |
Pull Request unblocked - code freeze is over.
@karianna My previous review still stands |
Miro does not give me the option to export to .gif |
For comparison (I screenshotted this on a 1080p display so not perfect) - these are about 150Kb in total. -rw-r--r--. 1 sxa sxa 32979 May 19 09:58 inframap-other.gif |
Thought it would be best for these to be in the docs folder, and then a link to them on the main page. What do people think?