Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Windows 2016 Docker image (O/S no longer in support) #2440

Merged
merged 3 commits into from
May 30, 2022

Conversation

karianna
Copy link
Contributor

Checklist
  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

Copy link
Contributor

@Willsparker Willsparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may as well remove the Win2016 Vagrantfile entirely - It's not part of VPC, and I assume there's no scope to add it to VPC, if it's out of support :-)

@karianna
Copy link
Contributor Author

We may as well remove the Win2016 Vagrantfile entirely - It's not part of VPC, and I assume there's no scope to add it to VPC, if it's out of support :-)

Shall I remove the 2012 as well in that case?

@Willsparker
Copy link
Contributor

We use 2012 for VPC :)

@karianna
Copy link
Contributor Author

We use 2012 for VPC :)

Updated, I think I caught all of the references

@karianna
Copy link
Contributor Author

It does beg the question of whether we should add 2019/2022 instead.

@Willsparker
Copy link
Contributor

I certainly wouldn't be opposed to adding a newer one, however we'd still be blocked by #2178 . Maybe worth opening an issue as a future enhancement, after we've resolved that

@karianna karianna marked this pull request as ready for review January 20, 2022 14:44
Copy link
Contributor

@Willsparker Willsparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added ghActions GitHub Actions and removed ghActions GitHub Actions labels May 30, 2022
@sxa
Copy link
Member

sxa commented May 30, 2022

@karianna Would be good to have 2019 since you have requested to use that for JDK19 #2490

I've resolved the merge conflicts in this so I'm going to merge it once the checks pass since it's been sitting for a while :-)

@sxa sxa merged commit 5898030 into adoptium:master May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants