Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spinner while loading data #346

Merged
merged 3 commits into from
Sep 19, 2023

Conversation

xavierfacq
Copy link
Member

Changes:

Add a spinner while loading data to avoid blank page

image

@netlify
Copy link

netlify bot commented Sep 19, 2023

Deploy Preview for eclipsefdn-adoptium-dash ready!

Name Link
🔨 Latest commit 74a26bb
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium-dash/deploys/650965fb33cbf300096c15e8
😎 Deploy Preview https://deploy-preview-346--eclipsefdn-adoptium-dash.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@gdams
Copy link
Member

gdams commented Sep 19, 2023

@xavierfacq there are some linter failures which you can fix locally with standard --fix

@xavierfacq xavierfacq marked this pull request as ready for review September 19, 2023 09:17
@gdams gdams merged commit 194234b into adoptium:main Sep 19, 2023
5 checks passed
@xavierfacq xavierfacq deleted the feature/add_spinner_while_loading branch October 5, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants