Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Certificate Import Issue by Generating Unique Aliases in cacert script #642

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

gdams
Copy link
Member

@gdams gdams commented Aug 27, 2024

Fixes #640

Fix confirmed to be working #640 (comment)

@gdams gdams force-pushed the cacert branch 3 times, most recently from f8c2558 to 8810ab6 Compare August 27, 2024 09:49
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.

If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.

If the code freeze is over you can remove this block by commenting /thaw.

@gdams
Copy link
Member Author

gdams commented Oct 21, 2024

/merge - it makes sense to get this merged ahead of the release. The reporter has confirmed this fixes things

Copy link
Contributor

Approval to merge during the lockdown cycle

Please can two Adoptium PMC members comment /approve?

Copy link
Contributor

@andrew-m-leonard andrew-m-leonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good I think

@andrew-m-leonard
Copy link
Contributor

/approve

Copy link

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me.

@gdams
Copy link
Member Author

gdams commented Oct 21, 2024

/approve

@github-actions github-actions bot dismissed their stale review October 21, 2024 16:54

Thank you @andrew-m-leonard and @gdams for your approvals, this pull request is now approved to merge during release.

@gdams gdams merged commit fb7ceb1 into adoptium:main Oct 21, 2024
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Duplicate alias issue in __cacert_entrypoint.sh when distributing new intermediate certificates
3 participants