Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify arch logic to be distro independent #568

Merged
merged 1 commit into from
May 31, 2024
Merged

simplify arch logic to be distro independent #568

merged 1 commit into from
May 31, 2024

Conversation

gdams
Copy link
Member

@gdams gdams commented May 30, 2024

This cleans up the the case statements in the dockerfiles to make them easier to read

tellison
tellison approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@tellison tellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know I've said it before, but it would be good if we used stable URLs from the Adoptium API for the BINARY_URL rather than reaching into the GitHub blob store. But that's not related to this change :-)

@gdams gdams enabled auto-merge (squash) May 30, 2024 16:02
@gdams gdams requested a review from karianna May 30, 2024 20:50
karianna
karianna approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same sentiment as Tim

@gdams gdams merged commit b65ebd7 into adoptium:main May 31, 2024
73 checks passed
@gdams gdams deleted the objdump branch May 31, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tellison tellison tellison approved these changes

@karianna karianna karianna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gdams @karianna @tellison