-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update reproduce_comparison to return UNSTABLE for differences found #807
Update reproduce_comparison to return UNSTABLE for differences found #807
Conversation
Signed-off-by: Andrew Leonard <[email protected]>
Thank you for creating a pull request!Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work). Code Quality and Contributing GuidelinesIf you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before. TestsGithub actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation. In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post |
Signed-off-by: Andrew Leonard <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be better if the return code of https://github.com/adoptium/temurin-build/blob/master/tooling/repro_compare.sh can be differentiated as 0 ( same ), 1( errors), 2 (different). Correspondingly the jenkins jobs status would be SUCCESS, FAILURE, UNSTABLE. If @andrew-m-leonard agree I can open a separate issue in temurin repo.
Yes please @sophia-guo good plan |
This also somewhat relates to converting this to a real test case (where there are specific / defined error codes and messages). |
…doptium#807) * Update reproduce_comparison to return UNSTABLE for differences found Signed-off-by: Andrew Leonard <[email protected]> * Update reproduce_comparison to return UNSTABLE for differences found Signed-off-by: Andrew Leonard <[email protected]> --------- Signed-off-by: Andrew Leonard <[email protected]>
Fixes #791
Updated results to UNSTABLE if repro_compare returns a difference.
Also changed failures to un-tar to be FAILUREs.
Test compare: https://ci.adoptium.net/view/ReproducibleBuild/job/jdk21-mac-aarch64-temurin_reproduce_compare/7/