Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reproduce_comparison to return UNSTABLE for differences found #807

Merged
merged 2 commits into from
Sep 10, 2023

Conversation

andrew-m-leonard
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard commented Sep 6, 2023

Fixes #791

Updated results to UNSTABLE if repro_compare returns a difference.
Also changed failures to un-tar to be FAILUREs.

Test compare: https://ci.adoptium.net/view/ReproducibleBuild/job/jdk21-mac-aarch64-temurin_reproduce_compare/7/

@andrew-m-leonard andrew-m-leonard self-assigned this Sep 6, 2023
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

Copy link
Contributor

@sophia-guo sophia-guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be better if the return code of https://github.com/adoptium/temurin-build/blob/master/tooling/repro_compare.sh can be differentiated as 0 ( same ), 1( errors), 2 (different). Correspondingly the jenkins jobs status would be SUCCESS, FAILURE, UNSTABLE. If @andrew-m-leonard agree I can open a separate issue in temurin repo.

@andrew-m-leonard
Copy link
Contributor Author

it would be better if the return code of https://github.com/adoptium/temurin-build/blob/master/tooling/repro_compare.sh can be differentiated as 0 ( same ), 1( errors), 2 (different). Correspondingly the jenkins jobs status would be SUCCESS, FAILURE, UNSTABLE. If @andrew-m-leonard agree I can open a separate issue in temurin repo.

Yes please @sophia-guo good plan

@smlambert
Copy link
Contributor

This also somewhat relates to converting this to a real test case (where there are specific / defined error codes and messages).

@andrew-m-leonard andrew-m-leonard enabled auto-merge (squash) September 7, 2023 14:57
@andrew-m-leonard andrew-m-leonard merged commit 6d6d7cd into adoptium:master Sep 10, 2023
6 checks passed
luhenry pushed a commit to luhenry/adoptium-ci-jenkins-pipelines that referenced this pull request Feb 3, 2024
…doptium#807)

* Update reproduce_comparison to return UNSTABLE for differences found

Signed-off-by: Andrew Leonard <[email protected]>

* Update reproduce_comparison to return UNSTABLE for differences found

Signed-off-by: Andrew Leonard <[email protected]>

---------

Signed-off-by: Andrew Leonard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jdk17u & jdk21 comparable build job returns FAILURE status on difference found
4 participants