-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor daily status health check to handle triggered builds and verify published assets #799
Conversation
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I find the added condition to mark the build status as unhealthy when a build artefact is missing a bit noisy. I'd be primarily interested in a basic "is there a new EA binary to test available" message, which is now hard to discern on this extended status. Perhaps that's a non-issue, and this new status will mostly work fine, but if it turns out to be red 99% of the time, it starts to become less informative and becomes noise.
Perhaps we want two status answering the following to basic questions?
- Is a binary available for testing (used to be Linux x86_64)?
- Are there any missing artefacts? If so, which.
Thoughts?
Signed-off-by: Andrew Leonard <[email protected]>
@jerboaa Thanks for the Feedback.
|
Alright. If the intention is to keep this healthy, I have no concerns with this. We'll see how it goes. |
Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
…ify published assets (adoptium#799) * Daily stats for triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> * Update daily status to support tag triggered builds Signed-off-by: Andrew Leonard <[email protected]> --------- Signed-off-by: Andrew Leonard <[email protected]>
Fixes #787
Fixes #798
Update the daily Slack build pipeline health status:
Added job Parameters:
FEATURE_RELEASES: List of jdkNNu releases to get status of
TIP_RELEASE: Optional jdk(head) release version (eg.jdk22)
BINARIES_REPO: github.com binaries repo template (eg.adoptium/temurin_NN_-binaries)
BUILD_CONFIG_URL: URL of raw ci-jenkins-piplines pipeline configuration for obtaining required Arch's for version
Test Slack status example: https://adoptium.slack.com/archives/C598A7EMQ/p1693580500301949
Missing Windows SBOM artifacts discovered with this work, raised as issue: adoptium/temurin-build#3464