Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build sbom gen and sign tools #732

Merged
merged 3 commits into from
Jul 6, 2023
Merged

Conversation

sophia-guo
Copy link
Contributor

@sophia-guo sophia-guo commented Jun 16, 2023

Related #610

Depends on adoptium/temurin-build#3404

Signed-off-by: Sophia Guo [email protected]

Signed-off-by: Sophia Guo <[email protected]>
@github-actions
Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,20"

@sophia-guo sophia-guo self-assigned this Jun 16, 2023
} catch (Exception e) {
slackSend channel: 'jenkins', color: 'danger', message: "${env.JOB_NAME} : #${env.BUILD_NUMBER} : ${stageName}() FAILED with following error message:\n${e}", teamDomain: 'adoptium'
//slackSend channel: 'jenkins', color: 'danger', message: "${env.JOB_NAME} : #${env.BUILD_NUMBER} : ${stageName}() FAILED with following error message:\n${e}", teamDomain: 'adoptium'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why commented out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment for testing. Re-enabled. Thanks.

Signed-off-by: Sophia Guo <[email protected]>
@sophia-guo sophia-guo marked this pull request as draft June 19, 2023 17:39
@sophia-guo sophia-guo requested a review from smlambert July 6, 2023 13:43
@sophia-guo sophia-guo marked this pull request as ready for review July 6, 2023 13:43
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sophia-guo sophia-guo merged commit c3b1733 into adoptium:master Jul 6, 2023
luhenry pushed a commit to luhenry/adoptium-ci-jenkins-pipelines that referenced this pull request Feb 3, 2024
* Build temurin-sing/gen/-sbom.jar

Signed-off-by: Sophia Guo <[email protected]>

* Testing

Signed-off-by: Sophia Guo <[email protected]>

* Enable slack message

Signed-off-by: Sophia Guo <[email protected]>

---------

Signed-off-by: Sophia Guo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants