-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit docker label to linux special.system #1135
Conversation
Thank you for creating a pull request!Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work). Code Quality and Contributing GuidelinesIf you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before. TestsGithub actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation. In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a comment for future consideration only, does not block merging this PR.
@@ -433,7 +435,7 @@ class Build { | |||
DYNAMIC_COMPILE = true | |||
} | |||
def additionalTestLabel = buildConfig.ADDITIONAL_TEST_LABEL | |||
if (testType == 'dev.openjdk' || testType == 'special.system') { | |||
if (testType == 'dev.openjdk' || (testType == 'special.system' && jobName.contains('linux'))) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if this adversely affects others using our pipelines (this is specific to Temurin (Eclipse Adoptium 'vendor' specific). Since no one has complained about this already, I will assume no, but future enhancement would be to frame it to only affect if vendor == Eclipse Adoptium).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated with buildConfig.VARIANT == 'temurin' with comment.
Related adoptium/temurin-build#4025