Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Archive all taps after parallel run" #1040

Merged
merged 1 commit into from
May 29, 2024

Conversation

andrew-m-leonard
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard commented May 29, 2024

Reverts #1033
Related #1039

This change unfortunately breaks pipeline builds when enableTests=False as there are no .tap files.
I believe the change is not quite right as well, since you cannot assume in a JenkinsFile when you start a new Jenkins "worker" context that what is in the workspace is still there or even what you think it should be.
Given the pipeline jobs can run concurrently, if two pipeline jobs happen to complete at the same time, they will be allocated different workspace directories, eg: a made up example
openjdk21-pipeline#22 : /home/jenkins/workspace/build-scripts/openjdk21-pipeline
openjdk21-pipeline#23 : /home/jenkins/workspace/build-scripts/openjdk21-pipeline@2
So #23 might archive the .tap files from #22 !

A recent example is build https://ci.adoptium.net/job/build-scripts/job/openjdk11-pipeline/2704/artifact/
Whose top level AQAvitTapFiles.tar.gz does not contain the AIX tap files, because the "windows-x64-temurin" and "aix-ppc64-temurin" happened to complete at exactly the same time, and as a result "aix-ppc64-temurin" used workspace /home/jenkins/workspace/build-scripts/openjdk11-pipeline@2

ls -l  /home/jenkins/workspace/build-scripts/openjdk11-pipeline@2/target/aix/ppc64/temurin/AQAvitTaps
-rw-r--r-- 1 jenkins jenkins   3122 May 24 21:59 Test_openjdk11_hs_dev.functional_ppc64_aix_testList_0.tap
-rw-r--r-- 1 jenkins jenkins   4308 May 24 22:25 Test_openjdk11_hs_extended.functional_ppc64_aix_testList_0.tap
-rw-r--r-- 1 jenkins jenkins   3445 May 25 17:57 Test_openjdk11_hs_extended.openjdk_ppc64_aix_rerun.tap
-rw-r--r-- 1 jenkins jenkins  10916 May 25 13:28 Test_openjdk11_hs_extended.openjdk_ppc64_aix_testList_0.tap
-rw-r--r-- 1 jenkins jenkins   4031 May 24 22:17 Test_openjdk11_hs_extended.perf_ppc64_aix_testList_0.tap
-rw-r--r-- 1 jenkins jenkins   3381 May 24 23:18 Test_openjdk11_hs_extended.system_ppc64_aix_rerun.tap
-rw-r--r-- 1 jenkins jenkins 727597 May 24 22:55 Test_openjdk11_hs_extended.system_ppc64_aix_testList_0.tap
-rw-r--r-- 1 jenkins jenkins   3430 May 24 22:06 Test_openjdk11_hs_sanity.functional_ppc64_aix_testList_0.tap
-rw-r--r-- 1 jenkins jenkins   3078 May 25 02:03 Test_openjdk11_hs_sanity.openjdk_ppc64_aix_rerun.tap
-rw-r--r-- 1 jenkins jenkins   6141 May 25 01:50 Test_openjdk11_hs_sanity.openjdk_ppc64_aix_testList_0.tap
-rw-r--r-- 1 jenkins jenkins   3258 May 24 22:23 Test_openjdk11_hs_sanity.perf_ppc64_aix_testList_0.tap
-rw-r--r-- 1 jenkins jenkins  13898 May 25 01:43 Test_openjdk11_hs_sanity.system_ppc64_aix_testList_0.tap
-rw-r--r-- 1 jenkins jenkins  15995 May 24 21:53 Test_openjdk11_hs_special.functional_ppc64_aix_testList_0.tap
-rw-r--r-- 1 jenkins jenkins  17899 May 24 21:45 Test_openjdk11_hs_special.functional_ppc64_aix_testList_1.tap
-rw-r--r-- 1 jenkins jenkins   3666 May 24 22:04 Test_openjdk11_hs_special.openjdk_ppc64_aix_testList_0.tap

@andrew-m-leonard andrew-m-leonard self-assigned this May 29, 2024
Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@sophia-guo
Copy link
Contributor

In case this close #1039, I have updated the description from fix #1039 to related #1039

@github-actions github-actions bot added aix testing windows x64 Issues that affect or relate to the x64/x32 LINUX OS labels May 29, 2024
@andrew-m-leonard andrew-m-leonard merged commit 55ef5db into master May 29, 2024
12 checks passed
@andrew-m-leonard andrew-m-leonard deleted the revert-1033-taps branch May 29, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aix jenkins-pipeline testing windows x64 Issues that affect or relate to the x64/x32 LINUX OS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants