Revert "Archive all taps after parallel run" #1040
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1033
Related #1039
This change unfortunately breaks pipeline builds when enableTests=False as there are no .tap files.
I believe the change is not quite right as well, since you cannot assume in a JenkinsFile when you start a new Jenkins "worker" context that what is in the workspace is still there or even what you think it should be.
Given the pipeline jobs can run concurrently, if two pipeline jobs happen to complete at the same time, they will be allocated different workspace directories, eg: a made up example
openjdk21-pipeline#22 : /home/jenkins/workspace/build-scripts/openjdk21-pipeline
openjdk21-pipeline#23 : /home/jenkins/workspace/build-scripts/openjdk21-pipeline@2
So #23 might archive the .tap files from #22 !
A recent example is build https://ci.adoptium.net/job/build-scripts/job/openjdk11-pipeline/2704/artifact/
Whose top level AQAvitTapFiles.tar.gz does not contain the AIX tap files, because the "windows-x64-temurin" and "aix-ppc64-temurin" happened to complete at exactly the same time, and as a result "aix-ppc64-temurin" used workspace /home/jenkins/workspace/build-scripts/openjdk11-pipeline@2