-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply USE_TESTENV_PROPERTIES only on container tests with aqa-tests #5406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LongyuZhang
force-pushed
the
envf1
branch
2 times, most recently
from
June 27, 2024 02:50
6d50bcb
to
8105da3
Compare
LongyuZhang
changed the title
Fix container ENV USE_TESTENV_PROPERTIES
Apply USE_TESTENV_PROPERTIE only on container tests with aqa-tests
Jun 27, 2024
LongyuZhang
force-pushed
the
envf1
branch
5 times, most recently
from
June 27, 2024 16:46
9736a1e
to
5e53f50
Compare
smlambert
changed the title
Apply USE_TESTENV_PROPERTIE only on container tests with aqa-tests
Apply USE_TESTENV_PROPERTIES only on container tests with aqa-tests
Jun 27, 2024
- Since container tests without github_url of aqa-tests don't need to inherit testenv - Modify USE_TESTENV_PROPERTIE to only apply with container tests with aqa-tests Signed-off-by: LongyuZhang <[email protected]>
Test Links:
and
|
sophia-guo
approved these changes
Jun 27, 2024
smlambert
approved these changes
Jun 28, 2024
LongyuZhang
added a commit
to LongyuZhang/aqa-tests
that referenced
this pull request
Jun 28, 2024
…doptium#5406) - Since container tests without github_url of aqa-tests don't need to inherit testenv - Modify USE_TESTENV_PROPERTIES to only apply with container tests with aqa-tests Signed-off-by: LongyuZhang <[email protected]>
sophia-guo
pushed a commit
that referenced
this pull request
Jun 28, 2024
…5406) (#5411) - Since container tests without github_url of aqa-tests don't need to inherit testenv - Modify USE_TESTENV_PROPERTIES to only apply with container tests with aqa-tests Signed-off-by: LongyuZhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: Non-container external tests broken #5403