Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collecting release tap files #5404

Merged
merged 3 commits into from
Jun 28, 2024
Merged

Collecting release tap files #5404

merged 3 commits into from
Jun 28, 2024

Conversation

sophia-guo
Copy link
Contributor

@sophia-guo sophia-guo commented Jun 25, 2024

Close #5242

Taps files attached to release triage issue
Taps Tar files of release pipeline line jobs

Archived - can be consumed by verification jobs as jenkins 's archive artifacts ( url )

@sophia-guo
Copy link
Contributor Author

Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the order of the parameters comment I added, this LGTM.

Comment on lines 4 to 5
string(name: 'RELEASE_TRIAGE_ISSUE_NUMBER', defaultValue: '', description: 'Triage issue number')
string(name: 'RELEASE_TRIAGE_REPO', defaultValue: 'adoptium/aqa-tests', description: 'Triage repo')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind to put the TRIAGE_REPO first, and the TRIAGE_ISSUE_NUMBER after it? Matches the ordering we use in other pipelines and in the case of jobName followed by jobNumber

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

copyArtifacts (
filter: "AQAvitTaps/${tapTars}",
fingerprintArtifacts: true,
projectName: "build-scripts/openjdk21-pipeline", //"${Release_PipelineJob_Name}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"${Release_PipelineJob_Name}" maybe ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks!

Signed-off-by: Sophia Guo <[email protected]>
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sophia-guo sophia-guo merged commit d98becb into adoptium:master Jun 28, 2024
2 checks passed
@sophia-guo
Copy link
Contributor Author

LongyuZhang pushed a commit to LongyuZhang/aqa-tests that referenced this pull request Jun 28, 2024
* Initail JenkinsFile

Signed-off-by: Sophia Guo <[email protected]>

* Initial tap collection jenkinsfile

Signed-off-by: Sophia Guo <[email protected]>

* Format update

Signed-off-by: Sophia Guo <[email protected]>

---------

Signed-off-by: Sophia Guo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify the process of final AQAvit results archives for release
3 participants