Skip to content

Commit

Permalink
Avoid unnecessary copying of system lib files
Browse files Browse the repository at this point in the history
- Ensure system lib files are only copied when isSVTTestRepo is set to true
- Prevent unnecessary copying of system lib files to systemtest_prereqs directory

related:https://github.ibm.com/runtimes/backlog/issues/1457

Signed-off-by: Anna Babu Palathingal <[email protected]>
  • Loading branch information
annaibm committed Jul 12, 2024
1 parent dd87740 commit b19a350
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 15 deletions.
3 changes: 2 additions & 1 deletion buildenv/jenkins/JenkinsfileBase
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,6 @@ def setupEnv() {

env.LIGHT_WEIGHT_CHECKOUT = (params.LIGHT_WEIGHT_CHECKOUT == false) ? params.LIGHT_WEIGHT_CHECKOUT : true
env.GENERATE_JOBS = params.GENERATE_JOBS ?: false
env.isSVTTestRepo=false

if (JOB_NAME.contains("Grinder")) {
def currentDate = new Date()
Expand Down Expand Up @@ -511,6 +510,8 @@ def setup() {
VENDOR_TEST_BRANCHES = (params.VENDOR_TEST_BRANCHES) ? "--vendor_branches \"${params.VENDOR_TEST_BRANCHES}\"" : ""
VENDOR_TEST_DIRS = (params.VENDOR_TEST_DIRS) ? "--vendor_dirs \"${params.VENDOR_TEST_DIRS}\"" : ""
VENDOR_TEST_SHAS = (params.VENDOR_TEST_SHAS) ? "--vendor_shas \"${params.VENDOR_TEST_SHAS}\"" : ""
env.IS_SVT_TESTREPO = params.VENDOR_TEST_REPOS.contains('SVTTestRepo') ? true : false
echo "IS_SVT_TESTREPO is set to ${env.IS_SVT_TESTREPO}"

// handle three cases (true/false/null) in params.TEST_IMAGES_REQUIRED and params.DEBUG_IMAGES_REQUIRED
// Only set image required to false if params is set to false. In get.sh, the default value is true
Expand Down
6 changes: 1 addition & 5 deletions get.sh
Original file line number Diff line number Diff line change
Expand Up @@ -637,11 +637,7 @@ getVendorTestMaterial() {
continue
fi
fi

if [[ "$repoURL" =~ "SVTTestRepo" ]]; then
isSVTTestRepo=true
fi


echo "git clone ${branchOption} $repoURL $dest"
git clone -q --depth 1 $branchOption $repoURL $dest

Expand Down
11 changes: 2 additions & 9 deletions system/common.xml
Original file line number Diff line number Diff line change
Expand Up @@ -350,16 +350,9 @@
</copy>
</then>
</if>
<condition property="isSVTTestRepo" value="true">
<isset property="env.isSVTTestRepo"/>
</condition>
<condition property="isSVTTestRepo" value="false">
<not>
<isset property="env.isSVTTestRepo"/>
</not>
</condition>

<if>
<equals arg1="${isSVTTestRepo}" arg2="true"/>
<equals arg1="${env.IS_SVT_TESTREPO}" arg2="true"/>
<then>
<mkdir dir="${SYSTEMTEST_DEST}/systemtest_prereqs"/>
<mkdir dir="${TEST_ROOT}/systemtest_prereqs"/>
Expand Down

0 comments on commit b19a350

Please sign in to comment.