[CRISP-683] Add <sp-dropdown />
#95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuberoot
reviewed
Aug 1, 2019
Westbrook
force-pushed
the
westbrook/CRISP-683/dropdown
branch
2 times, most recently
from
1eacf98
to
306b39b
Compare
Westbrook
force-pushed
the
westbrook/CRISP-683/dropdown
branch
from
98f1609
to
7f064f9
Compare
Westbrook
commented
Aug 23, 2019
| protected get buttonContent(): TemplateResult[] { | ||
| return [ | ||
| html` | ||
| <svg |
There was a problem hiding this comment.
Added #155 to track getting this icon (and related icons) into the project more smoothly in the future.
| <slot></slot> | ||
| `} | ||
| </div> | ||
| ${this.invalid |
There was a problem hiding this comment.
Currently the sizing and spacing of the invalid and chevron icons are not 100% to Spectrum CSS spec, and I have created #156 to track making the uiicon styles available in this project.
| @@ -29,4 +29,5 @@ button { | |||
|
|
|||
| #selected { | |||
| flex-shrink: 0; | |||
| margin-top: 0; | |||
There was a problem hiding this comment.
This workaround is related to #156 in that the spacing on the icon is not correct without this override until the uiicon styles are available.
| this.setAttribute('role', 'menuitem'); | ||
| public connectedCallback(): void { | ||
| super.connectedCallback(); | ||
| if (!this.hasAttribute('role')) { |
There was a problem hiding this comment.
Allow the usage to determine the role of the element.
| }, | ||
| }); | ||
| this.dispatchEvent(queryRoleEvent); | ||
| this.setAttribute('role', queryRoleEvent.detail.role || 'menuitem'); |
There was a problem hiding this comment.
Make menuitem the default role.
andrewhatran
approved these changes
Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for the Dropdown pattern from Spectrum CSS: http://opensource.adobe.com/spectrum-css/2.13.0/docs/#dropdown
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: