Let Adobe Acrobat users test in FireFox #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Westbrook
commented
Dec 17, 2019
| this.addEventListener('keydown', this.handleKeydown); | ||
| }; | ||
|
|
||
| public stopListeningToKeyboard = (): void => { | ||
| console.warn('stop'); |
There was a problem hiding this comment.
And fix this, because I missed them before 🙈 🙇
cuberoot
approved these changes
Dec 17, 2019
|
Luckily Ben Farrell had been in a very similar place a year ago...even though he had forgotten about it: karma-runner/karma-firefox-launcher#89 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unblock testing FireFox when Adobe Acrobat is installed.
Motivation and Context
The test, duke!
How Has This Been Tested?
By running the tests!
Types of changes
Checklist: