-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow dashes when parsing broker rack #68
Conversation
16b8306
to
73118d7
Compare
73118d7
to
63e24a0
Compare
the tests are failing though with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@amuraru it is the flaky test again from It is also odd that it is flaky only in our fork, not in upstream. Cannot replicate it on local either. I will create a task for it, I already spent 1 day earlier this month on it, but could not find the root cause. :( |
Found it in upstream too. That test is a flaky one not only in our repo. LE: See explanation for upstream failure here, seems the same as we've seen in #67, but curiously enough, the nodeports are still not deleted even with that explicit cleanup. |
Description
This change allows for
-
(dash) in broker rack values when building the broker to rack map used when enabling parallel broker restarts.Type of Change